Skip to content

Commit

Permalink
pwm: tegra: Don't needlessly enable and disable the clock in .remove()
Browse files Browse the repository at this point in the history
There is no reason to enable the PWM clock just to assert the reset
control. (If the reset control depends on the clock this is a bug and
probably it doesn't because in .probe() the reset is deasserted without
the clock being enabled.)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Uwe Kleine-König authored and Thierry Reding committed Jun 30, 2021
1 parent 86f7fa7 commit 3b8b571
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/pwm/pwm-tegra.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,8 @@ static int tegra_pwm_probe(struct platform_device *pdev)
static int tegra_pwm_remove(struct platform_device *pdev)
{
struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);
int err;

err = clk_prepare_enable(pc->clk);
if (err < 0)
return err;

reset_control_assert(pc->rst);
clk_disable_unprepare(pc->clk);

return pwmchip_remove(&pc->chip);
}
Expand Down

0 comments on commit 3b8b571

Please sign in to comment.