Skip to content

Commit

Permalink
ipv4: Don't report neigh uptodate state in rtcache procfs.
Browse files Browse the repository at this point in the history
Soon routes will not have a cached neigh attached, nor will we
be able to necessarily go directly to a neigh from an arbitrary
route.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 5, 2012
1 parent a263b30 commit 3c521f2
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions net/ipv4/route.c
Original file line number Diff line number Diff line change
Expand Up @@ -418,13 +418,7 @@ static int rt_cache_seq_show(struct seq_file *seq, void *v)
"HHUptod\tSpecDst");
else {
struct rtable *r = v;
struct neighbour *n;
int len, HHUptod;

rcu_read_lock();
n = dst_get_neighbour_noref(&r->dst);
HHUptod = (n && (n->nud_state & NUD_CONNECTED)) ? 1 : 0;
rcu_read_unlock();
int len;

seq_printf(seq, "%s\t%08X\t%08X\t%8X\t%d\t%u\t%d\t"
"%08X\t%d\t%u\t%u\t%02X\t%d\t%1d\t%08X%n",
Expand All @@ -438,9 +432,7 @@ static int rt_cache_seq_show(struct seq_file *seq, void *v)
(int)((dst_metric(&r->dst, RTAX_RTT) >> 3) +
dst_metric(&r->dst, RTAX_RTTVAR)),
r->rt_key_tos,
-1,
HHUptod,
0, &len);
-1, 0, 0, &len);

seq_printf(seq, "%*s\n", 127 - len, "");
}
Expand Down

0 comments on commit 3c521f2

Please sign in to comment.