Skip to content

Commit

Permalink
cpufreq: pcc-cpufreq: Fix doorbell.access_width
Browse files Browse the repository at this point in the history
Commit 920de6e (ACPICA: Hardware: Enhance
acpi_hw_validate_register() with access_width/bit_offset awareness)
apparently exposed a latent bug, doorbell.access_width is initialized
to 64, but per Lv Zheng, it should be 4, and indeed, making that
change does bring pcc-cpufreq back to life.

Fixes: 920de6e (ACPICA: Hardware: Enhance acpi_hw_validate_register() with access_width/bit_offset awareness)
Suggested-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Mike Galbraith authored and Rafael J. Wysocki committed Jun 23, 2016
1 parent 33688ab commit 3c67a82
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/cpufreq/pcc-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void)
doorbell.space_id = reg_resource->space_id;
doorbell.bit_width = reg_resource->bit_width;
doorbell.bit_offset = reg_resource->bit_offset;
doorbell.access_width = 64;
doorbell.access_width = 4;
doorbell.address = reg_resource->address;

pr_debug("probe: doorbell: space_id is %d, bit_width is %d, "
Expand Down

0 comments on commit 3c67a82

Please sign in to comment.