Skip to content

Commit

Permalink
net: phy: DP83822: clear MISR2 register to disable interrupts
Browse files Browse the repository at this point in the history
[ Upstream commit 37c9d66 ]

MISR1 was cleared twice but the original author intention was probably
to clear MISR1 & MISR2 to completely disable interrupts. Fix it to
clear MISR2.

Fixes: 87461f7 ("net: phy: DP83822 initial driver submission")
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220309142228.761153-1-clement.leger@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Clément Léger authored and Greg Kroah-Hartman committed Mar 16, 2022
1 parent 21044e6 commit 3cf533f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/phy/dp83822.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
if (err < 0)
return err;

err = phy_write(phydev, MII_DP83822_MISR1, 0);
err = phy_write(phydev, MII_DP83822_MISR2, 0);
if (err < 0)
return err;

Expand Down

0 comments on commit 3cf533f

Please sign in to comment.