Skip to content

Commit

Permalink
LockD: manage garbage collection timeout per networks namespace
Browse files Browse the repository at this point in the history
This patch moves next_gc to per-net data.

Note: passed network can be NULL (when Lockd kthread is exiting of Lockd
module is removing).

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
Stanislav Kinsbursky authored and J. Bruce Fields committed Jul 27, 2012
1 parent 27adadd commit 3cf7fb0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
12 changes: 9 additions & 3 deletions fs/lockd/host.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

#include <net/ipv6.h>

#include "netns.h"

#define NLMDBG_FACILITY NLMDBG_HOSTCACHE
#define NLM_HOST_NRHASH 32
#define NLM_HOST_REBIND (60 * HZ)
Expand All @@ -41,7 +43,6 @@ static struct hlist_head nlm_client_hosts[NLM_HOST_NRHASH];
hlist_for_each_entry_safe((host), (pos), (next), \
(chain), h_hash)

static unsigned long next_gc;
static unsigned long nrhosts;
static DEFINE_MUTEX(nlm_host_mutex);

Expand Down Expand Up @@ -337,14 +338,15 @@ struct nlm_host *nlmsvc_lookup_host(const struct svc_rqst *rqstp,
.hostname_len = hostname_len,
.net = net,
};
struct lockd_net *ln = net_generic(net, lockd_net_id);

dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__,
(int)hostname_len, hostname, rqstp->rq_vers,
(rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp"));

mutex_lock(&nlm_host_mutex);

if (time_after_eq(jiffies, next_gc))
if (time_after_eq(jiffies, ln->next_gc))
nlm_gc_hosts(net);

chain = &nlm_server_hosts[nlm_hash_address(ni.sap)];
Expand Down Expand Up @@ -653,5 +655,9 @@ nlm_gc_hosts(struct net *net)
nlm_destroy_host_locked(host);
}

next_gc = jiffies + NLM_HOST_COLLECT;
if (net) {
struct lockd_net *ln = net_generic(net, lockd_net_id);

ln->next_gc = jiffies + NLM_HOST_COLLECT;
}
}
1 change: 1 addition & 0 deletions fs/lockd/netns.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

struct lockd_net {
unsigned int nlmsvc_users;
unsigned long next_gc;
};

extern int lockd_net_id;
Expand Down

0 comments on commit 3cf7fb0

Please sign in to comment.