Skip to content

Commit

Permalink
gfs2: Clean up initialization of "ip" in gfs2_create_inode
Browse files Browse the repository at this point in the history
Initialize variable "ip" earlier so that it can be used interchangeably
with "inode" everywhere.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
  • Loading branch information
Andreas Gruenbacher committed Dec 2, 2022
1 parent 761fdbb commit 3d0258b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/gfs2/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,12 +659,12 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
error = -ENOMEM;
if (!inode)
goto fail_gunlock;
ip = GFS2_I(inode);

error = posix_acl_create(dir, &mode, &default_acl, &acl);
if (error)
goto fail_gunlock;

ip = GFS2_I(inode);
error = gfs2_qa_get(ip);
if (error)
goto fail_free_acls;
Expand Down Expand Up @@ -821,7 +821,7 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
if (!free_vfs_inode)
mark_inode_dirty(inode);
set_bit(free_vfs_inode ? GIF_FREE_VFS_INODE : GIF_ALLOC_FAILED,
&GFS2_I(inode)->i_flags);
&ip->i_flags);
if (inode->i_state & I_NEW)
iget_failed(inode);
else
Expand Down

0 comments on commit 3d0258b

Please sign in to comment.