Skip to content

Commit

Permalink
TTY: serial: move the dereference below the NULL test
Browse files Browse the repository at this point in the history
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Wei Yongjun authored and Greg Kroah-Hartman committed Sep 10, 2012
1 parent 3dbc5ce commit 3d39aa6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion drivers/tty/serial/ioc3_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -1120,13 +1120,14 @@ static inline int do_read(struct uart_port *the_port, char *buf, int len)
struct ioc3_port *port = get_ioc3_port(the_port);
struct ring *inring;
struct ring_entry *entry;
struct port_hooks *hooks = port->ip_hooks;
struct port_hooks *hooks;
int byte_num;
char *sc;
int loop_counter;

BUG_ON(!(len >= 0));
BUG_ON(!port);
hooks = port->ip_hooks;

/* There is a nasty timing issue in the IOC3. When the rx_timer
* expires or the rx_high condition arises, we take an interrupt.
Expand Down
3 changes: 2 additions & 1 deletion drivers/tty/serial/ioc4_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -2069,13 +2069,14 @@ static inline int do_read(struct uart_port *the_port, unsigned char *buf,
struct ioc4_port *port = get_ioc4_port(the_port, 0);
struct ring *inring;
struct ring_entry *entry;
struct hooks *hooks = port->ip_hooks;
struct hooks *hooks;
int byte_num;
char *sc;
int loop_counter;

BUG_ON(!(len >= 0));
BUG_ON(!port);
hooks = port->ip_hooks;

/* There is a nasty timing issue in the IOC4. When the rx_timer
* expires or the rx_high condition arises, we take an interrupt.
Expand Down

0 comments on commit 3d39aa6

Please sign in to comment.