Skip to content

Commit

Permalink
irqchip/apple-aic: Fix refcount leak in aic_of_ic_init
Browse files Browse the repository at this point in the history
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: a5e8801 ("irqchip/apple-aic: Parse FIQ affinities from device-tree")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-4-linmq006@gmail.com
  • Loading branch information
Miaoqian Lin authored and Marc Zyngier committed Jun 9, 2022
1 parent b1ac803 commit 3d45670
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/irqchip/irq-apple-aic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
for_each_child_of_node(affs, chld)
build_fiq_affinity(irqc, chld);
}
of_node_put(affs);

set_handle_irq(aic_handle_irq);
set_handle_fiq(aic_handle_fiq);
Expand Down

0 comments on commit 3d45670

Please sign in to comment.