Skip to content

Commit

Permalink
net/mlx5e: Use netdev_info instead of pr_info
Browse files Browse the repository at this point in the history
The next patch will pass the mlx5e_priv struct to the
modify_header_match_supported method. Use this opportunity to refactor
the existing pr_info call to a netdev_info call.

Signed-off-by: Oz Shlomo <ozsh@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
  • Loading branch information
Oz Shlomo authored and Saeed Mahameed committed Jul 10, 2020
1 parent a7c119b commit 3d486ec
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -3138,7 +3138,8 @@ static int is_action_keys_supported(const struct flow_action_entry *act,
return 0;
}

static bool modify_header_match_supported(struct mlx5_flow_spec *spec,
static bool modify_header_match_supported(struct mlx5e_priv *priv,
struct mlx5_flow_spec *spec,
struct flow_action *flow_action,
u32 actions, bool ct_flow,
struct netlink_ext_ack *extack)
Expand Down Expand Up @@ -3177,7 +3178,8 @@ static bool modify_header_match_supported(struct mlx5_flow_spec *spec,
ip_proto != IPPROTO_UDP && ip_proto != IPPROTO_ICMP) {
NL_SET_ERR_MSG_MOD(extack,
"can't offload re-write of non TCP/UDP");
pr_info("can't offload re-write of ip proto %d\n", ip_proto);
netdev_info(priv->netdev, "can't offload re-write of ip proto %d\n",
ip_proto);
return false;
}

Expand Down Expand Up @@ -3212,7 +3214,7 @@ static bool actions_match_supported(struct mlx5e_priv *priv,
}

if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR)
return modify_header_match_supported(&parse_attr->spec,
return modify_header_match_supported(priv, &parse_attr->spec,
flow_action, actions,
ct_flow, extack);

Expand Down

0 comments on commit 3d486ec

Please sign in to comment.