Skip to content

Commit

Permalink
TTY: usb/u_serial use close_wait from tty_port
Browse files Browse the repository at this point in the history
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Apr 9, 2012
1 parent 35f95fd commit 3d5ea59
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/usb/gadget/u_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ struct gs_port {
bool openclose; /* open/close in progress */
u8 port_num;

wait_queue_head_t close_wait; /* wait for last close */

struct list_head read_pool;
int read_started;
int read_allocated;
Expand Down Expand Up @@ -885,7 +883,7 @@ static void gs_close(struct tty_struct *tty, struct file *file)
pr_debug("gs_close: ttyGS%d (%p,%p) done!\n",
port->port_num, tty, file);

wake_up_interruptible(&port->close_wait);
wake_up_interruptible(&port->port.close_wait);
exit:
spin_unlock_irq(&port->port_lock);
}
Expand Down Expand Up @@ -1035,7 +1033,6 @@ gs_port_alloc(unsigned port_num, struct usb_cdc_line_coding *coding)

tty_port_init(&port->port);
spin_lock_init(&port->port_lock);
init_waitqueue_head(&port->close_wait);
init_waitqueue_head(&port->drain_wait);

tasklet_init(&port->push, gs_rx_push, (unsigned long) port);
Expand Down Expand Up @@ -1194,7 +1191,7 @@ void gserial_cleanup(void)
tasklet_kill(&port->push);

/* wait for old opens to finish */
wait_event(port->close_wait, gs_closed(port));
wait_event(port->port.close_wait, gs_closed(port));

WARN_ON(port->port_usb != NULL);

Expand Down

0 comments on commit 3d5ea59

Please sign in to comment.