Skip to content

Commit

Permalink
nfsd4: no need for replay_owner in sessions case
Browse files Browse the repository at this point in the history
The replay_owner will never be used in the sessions case.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Apr 9, 2013
1 parent c383747 commit 3d74e6a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion fs/nfsd/nfs4proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
WARN_ON(status && open->op_created);
out:
nfsd4_cleanup_open_state(open, status);
if (open->op_openowner)
if (open->op_openowner && !nfsd4_has_session(cstate))
cstate->replay_owner = &open->op_openowner->oo_owner;
nfsd4_bump_seqid(cstate, status);
if (!cstate->replay_owner)
Expand Down
8 changes: 4 additions & 4 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -3666,7 +3666,8 @@ nfs4_preprocess_seqid_op(struct nfsd4_compound_state *cstate, u32 seqid,
if (status)
return status;
*stpp = openlockstateid(s);
cstate->replay_owner = (*stpp)->st_stateowner;
if (!nfsd4_has_session(cstate))
cstate->replay_owner = (*stpp)->st_stateowner;

return nfs4_seqid_op_checks(cstate, stateid, seqid, *stpp);
}
Expand Down Expand Up @@ -3858,10 +3859,9 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
oo->oo_last_closed_stid = stp;

if (list_empty(&oo->oo_owner.so_stateids)) {
if (cstate->minorversion) {
if (cstate->minorversion)
release_openowner(oo);
cstate->replay_owner = NULL;
} else {
else {
/*
* In the 4.0 case we need to keep the owners around a
* little while to handle CLOSE replay.
Expand Down

0 comments on commit 3d74e6a

Please sign in to comment.