Skip to content

Commit

Permalink
uprobes/powerpc: Kill arch_uprobe->ainsn
Browse files Browse the repository at this point in the history
powerpc has both arch_uprobe->insn and arch_uprobe->ainsn to
make the generic code happy. This is no longer needed after
the previous change, powerpc can just use "u32 insn".

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
  • Loading branch information
Oleg Nesterov committed Nov 20, 2013
1 parent 803200e commit 3d78e94
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions arch/powerpc/include/asm/uprobes.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ typedef ppc_opcode_t uprobe_opcode_t;

struct arch_uprobe {
union {
u8 insn[MAX_UINSN_BYTES];
u8 ixol[MAX_UINSN_BYTES];
u32 ainsn;
u32 insn;
u32 ixol;
};
};

Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/kernel/uprobes.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ bool arch_uprobe_skip_sstep(struct arch_uprobe *auprobe, struct pt_regs *regs)
* emulate_step() returns 1 if the insn was successfully emulated.
* For all other cases, we need to single-step in hardware.
*/
ret = emulate_step(regs, auprobe->ainsn);
ret = emulate_step(regs, auprobe->insn);
if (ret > 0)
return true;

Expand Down

0 comments on commit 3d78e94

Please sign in to comment.