Skip to content

Commit

Permalink
toshiba: Remove extern from function prototypes
Browse files Browse the repository at this point in the history
There are a mix of function prototypes with and without extern
in the kernel sources.  Standardize on not using extern for
function prototypes.

Function prototypes don't need to be written with extern.
extern is assumed by the compiler.  Its use is as unnecessary as
using auto to declare automatic/local variables in a block.

Signed-off-by: Joe Perches <joe@perches.com>
  • Loading branch information
Joe Perches committed Sep 24, 2013
1 parent 95f7f15 commit 3e0dd1f
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 20 deletions.
29 changes: 14 additions & 15 deletions drivers/net/ethernet/toshiba/ps3_gelic_net.h
Original file line number Diff line number Diff line change
Expand Up @@ -359,27 +359,26 @@ static inline void *port_priv(struct gelic_port *port)
}

#ifdef CONFIG_PPC_EARLY_DEBUG_PS3GELIC
extern void udbg_shutdown_ps3gelic(void);
void udbg_shutdown_ps3gelic(void);
#else
static inline void udbg_shutdown_ps3gelic(void) {}
#endif

extern int gelic_card_set_irq_mask(struct gelic_card *card, u64 mask);
int gelic_card_set_irq_mask(struct gelic_card *card, u64 mask);
/* shared netdev ops */
extern void gelic_card_up(struct gelic_card *card);
extern void gelic_card_down(struct gelic_card *card);
extern int gelic_net_open(struct net_device *netdev);
extern int gelic_net_stop(struct net_device *netdev);
extern int gelic_net_xmit(struct sk_buff *skb, struct net_device *netdev);
extern void gelic_net_set_multi(struct net_device *netdev);
extern void gelic_net_tx_timeout(struct net_device *netdev);
extern int gelic_net_change_mtu(struct net_device *netdev, int new_mtu);
extern int gelic_net_setup_netdev(struct net_device *netdev,
struct gelic_card *card);
void gelic_card_up(struct gelic_card *card);
void gelic_card_down(struct gelic_card *card);
int gelic_net_open(struct net_device *netdev);
int gelic_net_stop(struct net_device *netdev);
int gelic_net_xmit(struct sk_buff *skb, struct net_device *netdev);
void gelic_net_set_multi(struct net_device *netdev);
void gelic_net_tx_timeout(struct net_device *netdev);
int gelic_net_change_mtu(struct net_device *netdev, int new_mtu);
int gelic_net_setup_netdev(struct net_device *netdev, struct gelic_card *card);

/* shared ethtool ops */
extern void gelic_net_get_drvinfo(struct net_device *netdev,
struct ethtool_drvinfo *info);
extern void gelic_net_poll_controller(struct net_device *netdev);
void gelic_net_get_drvinfo(struct net_device *netdev,
struct ethtool_drvinfo *info);
void gelic_net_poll_controller(struct net_device *netdev);

#endif /* _GELIC_NET_H */
6 changes: 3 additions & 3 deletions drivers/net/ethernet/toshiba/ps3_gelic_wireless.h
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ struct gelic_eurus_cmd {
#define GELIC_WL_PRIV_SET_PSK (SIOCIWFIRSTPRIV + 0)
#define GELIC_WL_PRIV_GET_PSK (SIOCIWFIRSTPRIV + 1)

extern int gelic_wl_driver_probe(struct gelic_card *card);
extern int gelic_wl_driver_remove(struct gelic_card *card);
extern void gelic_wl_interrupt(struct net_device *netdev, u64 status);
int gelic_wl_driver_probe(struct gelic_card *card);
int gelic_wl_driver_remove(struct gelic_card *card);
void gelic_wl_interrupt(struct net_device *netdev, u64 status);
#endif /* _GELIC_WIRELESS_H */
4 changes: 2 additions & 2 deletions drivers/net/ethernet/toshiba/spider_net.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@

#include <linux/sungem_phy.h>

extern int spider_net_stop(struct net_device *netdev);
extern int spider_net_open(struct net_device *netdev);
int spider_net_stop(struct net_device *netdev);
int spider_net_open(struct net_device *netdev);

extern const struct ethtool_ops spider_net_ethtool_ops;

Expand Down

0 comments on commit 3e0dd1f

Please sign in to comment.