Skip to content

Commit

Permalink
ata: pata_samsung_cf: Use devm_ioremap_resource()
Browse files Browse the repository at this point in the history
Use devm_ioremap_resource() in order to make the code simpler,
and remove redundant return value check of platform_get_resource()
because the value is checked by devm_ioremap_resource().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Jingoo Han authored and Tejun Heo committed Jan 2, 2014
1 parent 15e5318 commit 3e692a9
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions drivers/ata/pata_samsung_cf.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,22 +531,10 @@ static int __init pata_s3c_probe(struct platform_device *pdev)
info->irq = platform_get_irq(pdev, 0);

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res == NULL) {
dev_err(dev, "failed to get mem resource\n");
return -EINVAL;
}

if (!devm_request_mem_region(dev, res->start,
resource_size(res), DRV_NAME)) {
dev_err(dev, "error requesting register region\n");
return -EBUSY;
}

info->ide_addr = devm_ioremap(dev, res->start, resource_size(res));
if (!info->ide_addr) {
dev_err(dev, "failed to map IO base address\n");
return -ENOMEM;
}
info->ide_addr = devm_ioremap_resource(dev, res);
if (IS_ERR(info->ide_addr))
return PTR_ERR(info->ide_addr);

info->clk = devm_clk_get(&pdev->dev, "cfcon");
if (IS_ERR(info->clk)) {
Expand Down

0 comments on commit 3e692a9

Please sign in to comment.