Skip to content

Commit

Permalink
ASoC: mediatek: mt2701: fix return value check in mt2701_afe_pcm_dev_…
Browse files Browse the repository at this point in the history
…probe()

In case of error, the function syscon_node_to_regmap() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: dfa3cbb ("ASoC: mediatek: modify MT2701 AFE driver to adapt mfd device")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Wei Yongjun authored and Mark Brown committed Jan 8, 2018
1 parent 7f12a56 commit 3e8052d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1440,9 +1440,9 @@ static int mt2701_afe_pcm_dev_probe(struct platform_device *pdev)
}

afe->regmap = syscon_node_to_regmap(dev->parent->of_node);
if (!afe->regmap) {
if (IS_ERR(afe->regmap)) {
dev_err(dev, "could not get regmap from parent\n");
return -ENODEV;
return PTR_ERR(afe->regmap);
}

mutex_init(&afe->irq_alloc_lock);
Expand Down

0 comments on commit 3e8052d

Please sign in to comment.