Skip to content

Commit

Permalink
dt-bindings: leds: lp50xx: correct reg/unit addresses in example
Browse files Browse the repository at this point in the history
The multi-led node defined address/size cells, so it is intended to have
children with unit addresses.

The second multi-led's reg property defined three LED indexes within one
reg item, which is not correct - these are three separate items.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220607075247.58048-1-krzysztof.kozlowski@linaro.org
  • Loading branch information
Krzysztof Kozlowski authored and Rob Herring committed Jul 21, 2022
1 parent e76f4a6 commit 3eb229f
Showing 1 changed file with 15 additions and 9 deletions.
24 changes: 15 additions & 9 deletions Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,35 +99,41 @@ examples:
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_CHARGING;
led-0 {
led@0 {
reg = <0x0>;
color = <LED_COLOR_ID_RED>;
};
led-1 {
led@1 {
reg = <0x1>;
color = <LED_COLOR_ID_GREEN>;
};
led-2 {
led@2 {
reg = <0x2>;
color = <LED_COLOR_ID_BLUE>;
};
};
multi-led@2 {
multi-led@3 {
#address-cells = <1>;
#size-cells = <2>;
reg = <0x2 0x3 0x5>;
#size-cells = <0>;
reg = <0x3>, <0x4>, <0x5>;
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STANDBY;
led-6 {
led@3 {
reg = <0x3>;
color = <LED_COLOR_ID_RED>;
};
led-7 {
led@4 {
reg = <0x4>;
color = <LED_COLOR_ID_GREEN>;
};
led-8 {
led@5 {
reg = <0x5>;
color = <LED_COLOR_ID_BLUE>;
};
};
Expand Down

0 comments on commit 3eb229f

Please sign in to comment.