Skip to content

Commit

Permalink
tracing/kprobe: Remove cleanup code unrelated to selftest
Browse files Browse the repository at this point in the history
This cleanup all kprobe events code is not related to the selftest
itself, and it can fail by the reason unrelated to this test.
If the test is successful, the generated events are cleaned up.
And if not, we cannot guarantee that the kprobe events will work
correctly. So, anyway, there is no need to clean it up.

Link: https://lore.kernel.org/all/171811265627.85078.16897867213512435822.stgit@devnote2/

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
  • Loading branch information
Masami Hiramatsu (Google) committed Jun 11, 2024
1 parent 41051da commit 3eddb03
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions kernel/trace/trace_kprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -2114,10 +2114,6 @@ static __init int kprobe_trace_self_tests_init(void)


end:
ret = dyn_events_release_all(&trace_kprobe_ops);
if (WARN_ONCE(ret, "error on cleaning up probes."))
warn++;

/*
* Wait for the optimizer work to finish. Otherwise it might fiddle
* with probes in already freed __init text.
Expand Down

0 comments on commit 3eddb03

Please sign in to comment.