Skip to content

Commit

Permalink
can: af_can: rename find_rcv_list() to can_rcv_list_find()
Browse files Browse the repository at this point in the history
This patch add the commonly used prefix "can_" to the find_rcv_list()
function and add the "find" to the end, as the function returns a struct
rcv_list. This improves the overall readability of the code.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Sep 4, 2019
1 parent ff7fbea commit 3ee6d2b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions net/can/af_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ static unsigned int effhash(canid_t can_id)
}

/**
* find_rcv_list - determine optimal filterlist inside device filter struct
* can_rcv_list_find - determine optimal filterlist inside device filter struct
* @can_id: pointer to CAN identifier of a given can_filter
* @mask: pointer to CAN mask of a given can_filter
* @d: pointer to the device filter struct
Expand All @@ -357,8 +357,8 @@ static unsigned int effhash(canid_t can_id)
* Constistency checked mask.
* Reduced can_id to have a preprocessed filter compare value.
*/
static struct hlist_head *find_rcv_list(canid_t *can_id, canid_t *mask,
struct can_dev_rcv_lists *dev_rcv_lists)
static struct hlist_head *can_rcv_list_find(canid_t *can_id, canid_t *mask,
struct can_dev_rcv_lists *dev_rcv_lists)
{
canid_t inv = *can_id & CAN_INV_FILTER; /* save flag before masking */

Expand Down Expand Up @@ -460,7 +460,7 @@ int can_rx_register(struct net *net, struct net_device *dev, canid_t can_id,

dev_rcv_lists = find_dev_rcv_lists(net, dev);
if (dev_rcv_lists) {
rl = find_rcv_list(&can_id, &mask, dev_rcv_lists);
rl = can_rcv_list_find(&can_id, &mask, dev_rcv_lists);

r->can_id = can_id;
r->mask = mask;
Expand Down Expand Up @@ -533,7 +533,7 @@ void can_rx_unregister(struct net *net, struct net_device *dev, canid_t can_id,
goto out;
}

rl = find_rcv_list(&can_id, &mask, dev_rcv_lists);
rl = can_rcv_list_find(&can_id, &mask, dev_rcv_lists);

/* Search the receiver list for the item to delete. This should
* exist, since no receiver may be unregistered that hasn't
Expand Down

0 comments on commit 3ee6d2b

Please sign in to comment.