Skip to content

Commit

Permalink
auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code
Browse files Browse the repository at this point in the history
hex_to_bin() may be used to convert hexdecimal digit to its binary
representation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
  • Loading branch information
Andy Shevchenko authored and Miguel Ojeda committed May 29, 2020
1 parent 9cb1fd0 commit 3f03b64
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions drivers/auxdisplay/charlcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,24 +485,19 @@ static inline int handle_lcd_special_code(struct charlcd *lcd)
shift = 0;
value = 0;
while (*esc && cgoffset < 8) {
int half;

shift ^= 4;
if (*esc >= '0' && *esc <= '9') {
value |= (*esc - '0') << shift;
} else if (*esc >= 'A' && *esc <= 'F') {
value |= (*esc - 'A' + 10) << shift;
} else if (*esc >= 'a' && *esc <= 'f') {
value |= (*esc - 'a' + 10) << shift;
} else {
esc++;

half = hex_to_bin(*esc++);
if (half < 0)
continue;
}

value |= half << shift;
if (shift == 0) {
cgbytes[cgoffset++] = value;
value = 0;
}

esc++;
}

lcd->ops->write_cmd(lcd, LCD_CMD_SET_CGRAM_ADDR | (cgaddr * 8));
Expand Down

0 comments on commit 3f03b64

Please sign in to comment.