Skip to content

Commit

Permalink
brcmfmac: no fws locking outside fws module.
Browse files Browse the repository at this point in the history
FWS uses locking to protect its data while being called from
various entries. On bus_txdata the lock was kept resulting in
unnecessary long locking, but also creating possibility for
deadlock. This update changes the locking to release lock when
bus_txdata is called.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Hante Meuleman authored and John W. Linville committed Aug 15, 2013
1 parent 0a4254b commit 3f4f910
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 66 deletions.
1 change: 0 additions & 1 deletion drivers/net/wireless/brcm80211/brcmfmac/dhd.h
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,6 @@ struct brcmf_pub {
struct brcmf_fweh_info fweh;

struct brcmf_fws_info *fws;
spinlock_t fws_spinlock;

struct brcmf_ampdu_rx_reorder
*reorder_flows[BRCMF_AMPDU_RX_REORDER_MAXFLOWS];
Expand Down
Loading

0 comments on commit 3f4f910

Please sign in to comment.