Skip to content

Commit

Permalink
[PATCH] ps3: introduce CONFIG_PS3_ADVANCED
Browse files Browse the repository at this point in the history
ps3: Introduce CONFIG_PS3_ADVANCED, as suggested by Roman Zippel, and use
it to control questions about PS3 subsystems that may not be obvious for
the casual user.

This gets rid of the following warning on non-powerpc platforms: |
drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3'
refer to undefined symbol 'PS3_PS3AV'

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Geert Uytterhoeven authored and Linus Torvalds committed Mar 1, 2007
1 parent 8a2bfdc commit 3f555c7
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 9 deletions.
28 changes: 21 additions & 7 deletions arch/powerpc/platforms/ps3/Kconfig
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
menu "PS3 Platform Options"
depends on PPC_PS3

config PS3_ADVANCED
depends on PPC_PS3
bool "PS3 Advanced configuration options"
help
This gives you access to some advanced options for the PS3. The
defaults should be fine for most users, but these options may make
it possible to better control the kernel configuration if you know
what you are doing.

Note that the answer to this question won't directly affect the
kernel: saying N will just cause the configurator to skip all
the questions about these options.

Most users should say N to this question.

config PS3_HTAB_SIZE
depends on PPC_PS3
int "PS3 Platform pagetable size"
int "PS3 Platform pagetable size" if PS3_ADVANCED
range 18 20
default 20
help
Expand Down Expand Up @@ -42,7 +57,7 @@ config PS3_USE_LPAR_ADDR

config PS3_VUART
depends on PPC_PS3
bool "PS3 Virtual UART support"
bool "PS3 Virtual UART support" if PS3_ADVANCED
default y
help
Include support for the PS3 Virtual UART.
Expand All @@ -52,9 +67,8 @@ config PS3_VUART
general, all users will say Y.

config PS3_PS3AV
tristate "PS3 AV settings driver"
depends on PPC_PS3
select PS3_VUART
tristate "PS3 AV settings driver" if PS3_ADVANCED
depends on PS3_VUART
default y
help
Include support for the PS3 AV Settings driver.
Expand All @@ -63,8 +77,8 @@ config PS3_PS3AV
general, all users will say Y or M.

config PS3_SYS_MANAGER
bool "PS3 System Manager driver"
select PS3_VUART
bool "PS3 System Manager driver" if PS3_ADVANCED
depends on PS3_VUART
default y
help
Include support for the PS3 System Manager.
Expand Down
3 changes: 1 addition & 2 deletions drivers/video/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1618,8 +1618,7 @@ config FB_IBM_GXT4500

config FB_PS3
bool "PS3 GPU framebuffer driver"
depends on FB && PPC_PS3
select PS3_PS3AV
depends on FB && PS3_PS3AV
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
Expand Down

0 comments on commit 3f555c7

Please sign in to comment.