Skip to content

Commit

Permalink
ASoC: convert rk3328 codec binding to yaml
Browse files Browse the repository at this point in the history
This patch converts Rockchip rk3328 audio codec binding to DT schema.
And adds description about "mclk" clock and fixes some errors in
original example.

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20200714073247.172859-1-katsuhiro@katsuster.net
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Katsuhiro Suzuki authored and Mark Brown committed Jul 14, 2020
1 parent f50d67f commit 3f6597a
Show file tree
Hide file tree
Showing 2 changed files with 69 additions and 28 deletions.
28 changes: 0 additions & 28 deletions Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.txt

This file was deleted.

69 changes: 69 additions & 0 deletions Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/sound/rockchip,rk3328-codec.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Rockchip rk3328 internal codec

maintainers:
- Heiko Stuebner <heiko@sntech.de>

properties:
compatible:
const: rockchip,rk3328-codec

reg:
maxItems: 1

clocks:
items:
- description: clock for audio codec
- description: clock for I2S master clock

clock-names:
items:
- const: pclk
- const: mclk

rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
description:
The phandle of the syscon node for the GRF register.

spk-depop-time-ms:
default: 200
description:
Speaker depop time in msec.

mute-gpios:
maxItems: 1
description:
GPIO specifier for external line driver control (typically the
dedicated GPIO_MUTE pin)

"#sound-dai-cells":
const: 0

required:
- compatible
- reg
- clocks
- clock-names
- rockchip,grf
- "#sound-dai-cells"

examples:
- |
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/clock/rk3328-cru.h>
codec: codec@ff410000 {
compatible = "rockchip,rk3328-codec";
reg = <0xff410000 0x1000>;
clocks = <&cru PCLK_ACODECPHY>, <&cru SCLK_I2S1>;
clock-names = "pclk", "mclk";
rockchip,grf = <&grf>;
mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>;
spk-depop-time-ms = <100>;
#sound-dai-cells = <0>;
};

0 comments on commit 3f6597a

Please sign in to comment.