Skip to content

Commit

Permalink
Merge branch 'for-5.16/wacom' into for-linus
Browse files Browse the repository at this point in the history
- improvement of device management handling (Cai Huoqing, Jason Gerecke)
  • Loading branch information
Jiri Kosina committed Nov 5, 2021
2 parents a7c2b7e + 3d422a4 commit 3f81b3a
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions drivers/hid/wacom_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -881,31 +881,28 @@ static int wacom_add_shared_data(struct hid_device *hdev)
if (!data) {
data = kzalloc(sizeof(struct wacom_hdev_data), GFP_KERNEL);
if (!data) {
retval = -ENOMEM;
goto out;
mutex_unlock(&wacom_udev_list_lock);
return -ENOMEM;
}

kref_init(&data->kref);
data->dev = hdev;
list_add_tail(&data->list, &wacom_udev_list);
}

mutex_unlock(&wacom_udev_list_lock);

wacom_wac->shared = &data->shared;

retval = devm_add_action(&hdev->dev, wacom_remove_shared_data, wacom);
if (retval) {
mutex_unlock(&wacom_udev_list_lock);
wacom_remove_shared_data(wacom);
retval = devm_add_action_or_reset(&hdev->dev, wacom_remove_shared_data, wacom);
if (retval)
return retval;
}

if (wacom_wac->features.device_type & WACOM_DEVICETYPE_TOUCH)
wacom_wac->shared->touch = hdev;
else if (wacom_wac->features.device_type & WACOM_DEVICETYPE_PEN)
wacom_wac->shared->pen = hdev;

out:
mutex_unlock(&wacom_udev_list_lock);
return retval;
}

Expand Down

0 comments on commit 3f81b3a

Please sign in to comment.