Skip to content

Commit

Permalink
powerpc: 8xx: fix a return value error in mpc8xx_pic_init
Browse files Browse the repository at this point in the history
mpc8xx_pic_init() should return -ENOMEM instead of 0 when
irq_domain_add_linear() return NULL. This cause mpc8xx_pics_init to continue
executing even if mpc8xx_pic_host is NULL.

Fixes: cc76404 ("powerpc/8xx: Fix possible device node reference leak")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220223070223.26845-1-hbh25y@gmail.com
  • Loading branch information
Hangyu Hua authored and Michael Ellerman committed Mar 9, 2022
1 parent 9f51960 commit 3fd46e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/powerpc/platforms/8xx/pic.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ int __init mpc8xx_pic_init(void)
if (mpc8xx_pic_host == NULL) {
printk(KERN_ERR "MPC8xx PIC: failed to allocate irq host!\n");
ret = -ENOMEM;
goto out;
}

ret = 0;
Expand Down

0 comments on commit 3fd46e5

Please sign in to comment.