Skip to content

Commit

Permalink
spi: imx: use prepare_transfer_hardware() for lpspi
Browse files Browse the repository at this point in the history
The old driver enable clk in fsl_lpspi_prepare_message() and
disable clk in fsl_lpspi_unprepare_message().

Rather than doing this per message it's a bit better to do it
in prepare_transfer_hardware(), that way if there's a sequence
of messages queued one after another we don't turn the clock on
and off all the time.

Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Gao Pan authored and Mark Brown committed Nov 25, 2016
1 parent a17efbc commit 3ffa1a5
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions drivers/spi/spi-fsl-lpspi.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,14 @@ static void fsl_lpspi_intctrl(struct fsl_lpspi_data *fsl_lpspi,
writel(enable, fsl_lpspi->base + IMX7ULP_IER);
}

static int fsl_lpspi_prepare_message(struct spi_master *master,
struct spi_message *msg)
static int lpspi_prepare_xfer_hardware(struct spi_master *master)
{
struct fsl_lpspi_data *fsl_lpspi = spi_master_get_devdata(master);

return clk_prepare_enable(fsl_lpspi->clk);
}

static int
fsl_lpspi_unprepare_message(struct spi_master *master, struct spi_message *msg)
static int lpspi_unprepare_xfer_hardware(struct spi_master *master)
{
struct fsl_lpspi_data *fsl_lpspi = spi_master_get_devdata(master);

Expand Down Expand Up @@ -438,8 +436,8 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
fsl_lpspi->dev = &pdev->dev;

master->transfer_one_message = fsl_lpspi_transfer_one_msg;
master->prepare_message = fsl_lpspi_prepare_message;
master->unprepare_message = fsl_lpspi_unprepare_message;
master->prepare_transfer_hardware = lpspi_prepare_xfer_hardware;
master->unprepare_transfer_hardware = lpspi_unprepare_xfer_hardware;
master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH;
master->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX;
master->dev.of_node = pdev->dev.of_node;
Expand Down

0 comments on commit 3ffa1a5

Please sign in to comment.