Skip to content

Commit

Permalink
Revert "tty: goldfish: Fix a parameter of a call to free_irq"
Browse files Browse the repository at this point in the history
This reverts commit 01b3db2 which is
commit 1a5c2d1 upstream.

Ben writes:
	This fixes a bug introduced in 4.6 by commit 465893e "tty:
	goldfish: support platform_device with id -1".  For earlier
	kernel versions, it *introduces* a bug.

So let's drop it.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
  • Loading branch information
Greg Kroah-Hartman committed Oct 21, 2017
1 parent cdbbea7 commit 401231d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/goldfish.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ static int goldfish_tty_probe(struct platform_device *pdev)
return 0;

err_tty_register_device_failed:
free_irq(irq, qtty);
free_irq(irq, pdev);
err_request_irq_failed:
goldfish_tty_current_line_count--;
if (goldfish_tty_current_line_count == 0)
Expand Down

0 comments on commit 401231d

Please sign in to comment.