Skip to content

Commit

Permalink
powerpc/85xx: Add __init attribute to eligible functions
Browse files Browse the repository at this point in the history
Some functions defined in 'arch/powerpc/platforms/85xx' are deserving of an
`__init` macro attribute. These functions are only called by other
initialization functions and therefore should inherit the attribute.
Also, change function declarations in header files to include `__init`.

Signed-off-by: Nick Child <nick.child@ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211216220035.605465-19-nick.child@ibm.com
  • Loading branch information
Nick Child authored and Michael Ellerman committed Dec 23, 2021
1 parent f4a88b0 commit 407454c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/85xx/ge_imp3a.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ void __init ge_imp3a_pic_init(void)
of_node_put(cascade_node);
}

static void ge_imp3a_pci_assign_primary(void)
static void __init ge_imp3a_pci_assign_primary(void)
{
#ifdef CONFIG_PCI
struct device_node *np;
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/85xx/mpc85xx_cds.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ machine_device_initcall(mpc85xx_cds, mpc85xx_cds_8259_attach);

#endif /* CONFIG_PPC_I8259 */

static void mpc85xx_cds_pci_assign_primary(void)
static void __init mpc85xx_cds_pci_assign_primary(void)
{
#ifdef CONFIG_PCI
struct device_node *np;
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/85xx/socrates_fpga_pic.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ static const struct irq_domain_ops socrates_fpga_pic_host_ops = {
.xlate = socrates_fpga_pic_host_xlate,
};

void socrates_fpga_pic_init(struct device_node *pic)
void __init socrates_fpga_pic_init(struct device_node *pic)
{
unsigned long flags;
int i;
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/85xx/socrates_fpga_pic.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
#ifndef SOCRATES_FPGA_PIC_H
#define SOCRATES_FPGA_PIC_H

void socrates_fpga_pic_init(struct device_node *pic);
void __init socrates_fpga_pic_init(struct device_node *pic);

#endif
4 changes: 2 additions & 2 deletions arch/powerpc/platforms/85xx/xes_mpc85xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void __init xes_mpc85xx_pic_init(void)
mpic_init(mpic);
}

static void xes_mpc85xx_configure_l2(void __iomem *l2_base)
static void __init xes_mpc85xx_configure_l2(void __iomem *l2_base)
{
volatile uint32_t ctl, tmp;

Expand All @@ -72,7 +72,7 @@ static void xes_mpc85xx_configure_l2(void __iomem *l2_base)
asm volatile("msync; isync");
}

static void xes_mpc85xx_fixups(void)
static void __init xes_mpc85xx_fixups(void)
{
struct device_node *np;
int err;
Expand Down

0 comments on commit 407454c

Please sign in to comment.