Skip to content

Commit

Permalink
backlight: pwm_bl: Drop use of int_pow()
Browse files Browse the repository at this point in the history
For a fixed small exponent of 3, it is more efficient to simply use
two explicit multiplications rather than calling the int_pow() library
function: Aside from the function call overhead, its implementation
using repeated squaring means it ends up doing four 64x64
multiplications.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Rasmus Villemoes authored and Lee Jones committed Oct 14, 2019
1 parent e802cba commit 407feae
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/video/backlight/pwm_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ static u64 cie1931(unsigned int lightness, unsigned int scale)
if (lightness <= (8 * scale)) {
retval = DIV_ROUND_CLOSEST(lightness * 10, 9033);
} else {
retval = int_pow((lightness + (16 * scale)) / 116, 3);
retval = (lightness + (16 * scale)) / 116;
retval *= retval * retval;
retval = DIV_ROUND_CLOSEST_ULL(retval, (scale * scale));
}

Expand Down

0 comments on commit 407feae

Please sign in to comment.