Skip to content

Commit

Permalink
lan78xx: Remove unused pause frame queue
Browse files Browse the repository at this point in the history
Remove the pause frame queue from the driver. It is initialised
but not actually used.

Signed-off-by: John Efstathiades <john.efstathiades@pebblebay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
John Efstathiades authored and David S. Miller committed Aug 25, 2021
1 parent dc35f85 commit 40b8452
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions drivers/net/usb/lan78xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,6 @@ struct lan78xx_net {
struct sk_buff_head rxq;
struct sk_buff_head txq;
struct sk_buff_head done;
struct sk_buff_head rxq_pause;
struct sk_buff_head txq_pend;

struct tasklet_struct bh;
Expand Down Expand Up @@ -2710,8 +2709,6 @@ static int lan78xx_stop(struct net_device *net)

usb_kill_urb(dev->urb_intr);

skb_queue_purge(&dev->rxq_pause);

/* deferred work (task, timer, softirq) must also stop.
* can't flush_scheduled_work() until we drop rtnl (later),
* else workers could deadlock; so make workers a NOP.
Expand Down Expand Up @@ -3003,11 +3000,6 @@ static void lan78xx_skb_return(struct lan78xx_net *dev, struct sk_buff *skb)
{
int status;

if (test_bit(EVENT_RX_PAUSED, &dev->flags)) {
skb_queue_tail(&dev->rxq_pause, skb);
return;
}

dev->net->stats.rx_packets++;
dev->net->stats.rx_bytes += skb->len;

Expand Down Expand Up @@ -3674,7 +3666,6 @@ static int lan78xx_probe(struct usb_interface *intf,
skb_queue_head_init(&dev->rxq);
skb_queue_head_init(&dev->txq);
skb_queue_head_init(&dev->done);
skb_queue_head_init(&dev->rxq_pause);
skb_queue_head_init(&dev->txq_pend);
mutex_init(&dev->phy_mutex);

Expand Down

0 comments on commit 40b8452

Please sign in to comment.