Skip to content

Commit

Permalink
net: sxgbe: fix sparse warnings about static declaration
Browse files Browse the repository at this point in the history
This fixes followings:

sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:197:5:
sparse: symbol 'sxgbe_platform_freeze' was not declared. Should it be static?
>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:204:5:
sparse: symbol 'sxgbe_platform_restore' was not declared. Should it be static?
>> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:228:24:
sparse: symbol 'sxgbe_platform_driver' was not declared. Should it be static?

>> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1795:6:
sparse: symbol 'sxgbe_get_ops' was not declared. Should it be static?

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Byungho An <bh74.an@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Byungho An authored and David S. Miller committed Mar 28, 2014
1 parent 1d78472 commit 40b92ca
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2013,7 +2013,7 @@ static const struct net_device_ops sxgbe_netdev_ops = {
};

/* Get the hardware ops */
void sxgbe_get_ops(struct sxgbe_ops * const ops_ptr)
static void sxgbe_get_ops(struct sxgbe_ops * const ops_ptr)
{
ops_ptr->mac = sxgbe_get_core_ops();
ops_ptr->desc = sxgbe_get_desc_ops();
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,14 @@ static int sxgbe_platform_resume(struct device *dev)
return sxgbe_resume(ndev);
}

int sxgbe_platform_freeze(struct device *dev)
static int sxgbe_platform_freeze(struct device *dev)
{
struct net_device *ndev = dev_get_drvdata(dev);

return sxgbe_freeze(ndev);
}

int sxgbe_platform_restore(struct device *dev)
static int sxgbe_platform_restore(struct device *dev)
{
struct net_device *ndev = dev_get_drvdata(dev);

Expand All @@ -231,7 +231,7 @@ static const struct of_device_id sxgbe_dt_ids[] = {
};
MODULE_DEVICE_TABLE(of, sxgbe_dt_ids);

struct platform_driver sxgbe_platform_driver = {
static struct platform_driver sxgbe_platform_driver = {
.probe = sxgbe_platform_probe,
.remove = sxgbe_platform_remove,
.driver = {
Expand Down

0 comments on commit 40b92ca

Please sign in to comment.