Skip to content

Commit

Permalink
scsi: mpt3sas: Fix incorrectly assigned error return and check
Browse files Browse the repository at this point in the history
Currently the call to _base_static_config_pages() is assigning the error
return to variable 'rc' but checking the error return in error 'r'. Fix
this by assigning the error return to variable 'r' instead of 'rc'.

Link: https://lore.kernel.org/r/20210804134940.114011-1-colin.king@canonical.com
Fixes: 19a622c ("scsi: mpt3sas: Handle firmware faults during first half of IOC init")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Unused value")
  • Loading branch information
Colin Ian King authored and Martin K. Petersen committed Aug 10, 2021
1 parent dbe7633 commit 40d3272
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/mpt3sas/mpt3sas_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -7851,7 +7851,7 @@ _base_make_ioc_operational(struct MPT3SAS_ADAPTER *ioc)
return r;
}

rc = _base_static_config_pages(ioc);
r = _base_static_config_pages(ioc);
if (r)
return r;

Expand Down

0 comments on commit 40d3272

Please sign in to comment.