Skip to content

Commit

Permalink
rds: fix an infoleak in rds_inc_info_copy
Browse files Browse the repository at this point in the history
The last field "flags" of object "minfo" is not initialized.
Copying this object out may leak kernel stack data.
Assign 0 to it to avoid leak.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kangjie Lu authored and David S. Miller committed Jun 3, 2016
1 parent 5d2be14 commit 4116def
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/rds/recv.c
Original file line number Diff line number Diff line change
Expand Up @@ -561,5 +561,7 @@ void rds_inc_info_copy(struct rds_incoming *inc,
minfo.fport = inc->i_hdr.h_dport;
}

minfo.flags = 0;

rds_info_copy(iter, &minfo, sizeof(minfo));
}

0 comments on commit 4116def

Please sign in to comment.