Skip to content

Commit

Permalink
dm: introduce a new DM_MAPIO_KILL return value
Browse files Browse the repository at this point in the history
This untangles the DM_MAPIO_* values returned from ->clone_and_map_rq
from the error codes used by the block layer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Christoph Hellwig authored and Mike Snitzer committed May 1, 2017
1 parent 7ed8578 commit 412445a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
12 changes: 5 additions & 7 deletions drivers/md/dm-rq.c
Original file line number Diff line number Diff line change
Expand Up @@ -504,14 +504,12 @@ static int map_request(struct dm_rq_target_io *tio)
/* The target wants to requeue the I/O after a delay */
dm_requeue_original_request(tio, true);
break;
default:
if (r > 0) {
DMWARN("unimplemented target map return value: %d", r);
BUG();
}

case DM_MAPIO_KILL:
/* The target wants to complete the I/O */
dm_kill_unmapped_request(rq, r);
dm_kill_unmapped_request(rq, -EIO);
default:
DMWARN("unimplemented target map return value: %d", r);
BUG();
}

return r;
Expand Down
2 changes: 1 addition & 1 deletion drivers/md/dm-target.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ static int io_err_clone_and_map_rq(struct dm_target *ti, struct request *rq,
union map_info *map_context,
struct request **clone)
{
return -EIO;
return DM_MAPIO_KILL;
}

static void io_err_release_clone_rq(struct request *clone)
Expand Down
1 change: 1 addition & 0 deletions include/linux/device-mapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ extern struct ratelimit_state dm_ratelimit_state;
#define DM_MAPIO_REMAPPED 1
#define DM_MAPIO_REQUEUE DM_ENDIO_REQUEUE
#define DM_MAPIO_DELAY_REQUEUE 3
#define DM_MAPIO_KILL 4

#define dm_sector_div64(x, y)( \
{ \
Expand Down

0 comments on commit 412445a

Please sign in to comment.