Skip to content

Commit

Permalink
dt-bindings: net: renesas, ether: Improve schema validation
Browse files Browse the repository at this point in the history
- Remove pinctrl consumer properties, as they are handled by core
    dt-schema,
  - Document missing properties,
  - Document missing PHY child node,
  - Add "additionalProperties: false".

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Geert Uytterhoeven authored and David S. Miller committed Aug 20, 2020
1 parent 272502f commit 41506bf
Showing 1 changed file with 15 additions and 7 deletions.
22 changes: 15 additions & 7 deletions Documentation/devicetree/bindings/net/renesas,ether.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,15 @@ properties:
clocks:
maxItems: 1

pinctrl-0: true
power-domains:
maxItems: 1

resets:
maxItems: 1

pinctrl-names: true
phy-mode: true

phy-handle: true

renesas,no-ether-link:
type: boolean
Expand All @@ -74,6 +80,11 @@ properties:
specify when the Ether LINK signal is active-low instead of normal
active-high

patternProperties:
"^ethernet-phy@[0-9a-f]$":
type: object
$ref: ethernet-phy.yaml#

required:
- compatible
- reg
Expand All @@ -83,7 +94,8 @@ required:
- '#address-cells'
- '#size-cells'
- clocks
- pinctrl-0

additionalProperties: false

examples:
# Lager board
Expand All @@ -99,8 +111,6 @@ examples:
clocks = <&mstp8_clks R8A7790_CLK_ETHER>;
phy-mode = "rmii";
phy-handle = <&phy1>;
pinctrl-0 = <&ether_pins>;
pinctrl-names = "default";
renesas,ether-link-active-low;
#address-cells = <1>;
#size-cells = <0>;
Expand All @@ -109,7 +119,5 @@ examples:
reg = <1>;
interrupt-parent = <&irqc0>;
interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
pinctrl-0 = <&phy1_pins>;
pinctrl-names = "default";
};
};

0 comments on commit 41506bf

Please sign in to comment.