Skip to content

Commit

Permalink
HID: thrustmaster use swap() to make code cleaner
Browse files Browse the repository at this point in the history
Fix the following coccicheck REVIEW:
Use swap() instead of reimplementing it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
[bentiss: rewrote commit title]
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20211109082610.131341-1-chi.minghao@zte.com.cn
  • Loading branch information
chiminghao authored and Benjamin Tissoires committed Dec 14, 2021
1 parent 03090cc commit 415e701
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/hid/hid-tmff.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ static int tmff_play(struct input_dev *dev, void *data,
struct hid_field *ff_field = tmff->ff_field;
int x, y;
int left, right; /* Rumbling */
int motor_swap;

switch (effect->type) {
case FF_CONSTANT:
Expand All @@ -104,11 +103,8 @@ static int tmff_play(struct input_dev *dev, void *data,
ff_field->logical_maximum);

/* 2-in-1 strong motor is left */
if (hid->product == THRUSTMASTER_DEVICE_ID_2_IN_1_DT) {
motor_swap = left;
left = right;
right = motor_swap;
}
if (hid->product == THRUSTMASTER_DEVICE_ID_2_IN_1_DT)
swap(left, right);

dbg_hid("(left,right)=(%08x, %08x)\n", left, right);
ff_field->value[0] = left;
Expand Down

0 comments on commit 415e701

Please sign in to comment.