Skip to content

Commit

Permalink
x86/mm: Convert unreachable() to BUG()
Browse files Browse the repository at this point in the history
Commit 2190966 ("x86: Convert unreachable() to BUG()") missed
one.

And after commit 06e2474 ("objtool: Remove
annotate_{,un}reachable()") the invalid use of unreachable()
(rightfully) triggers warnings:

  vmlinux.o: warning: objtool: page_fault_oops() falls through to next function is_prefetch()

Fixes: 2190966 ("x86: Convert unreachable() to BUG()")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20241216093215.GD12338@noisy.programming.kicks-ass.net
  • Loading branch information
Peter Zijlstra committed Dec 17, 2024
1 parent c3cb6c1 commit 41a1e97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/mm/fault.c
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ page_fault_oops(struct pt_regs *regs, unsigned long error_code,
ASM_CALL_ARG3,
, [arg1] "r" (regs), [arg2] "r" (address), [arg3] "r" (&info));

unreachable();
BUG();
}
#endif

Expand Down

0 comments on commit 41a1e97

Please sign in to comment.