Skip to content

Commit

Permalink
drivers/net: Remove alloc_etherdev error messages
Browse files Browse the repository at this point in the history
alloc_etherdev has a generic OOM/unable to alloc message.
Remove the duplicative messages after alloc_etherdev calls.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Joe Perches authored and David S. Miller committed Jan 31, 2012
1 parent e404dec commit 41de8d4
Show file tree
Hide file tree
Showing 86 changed files with 63 additions and 192 deletions.
5 changes: 2 additions & 3 deletions drivers/net/ethernet/3com/3c59x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1121,10 +1121,9 @@ static int __devinit vortex_probe1(struct device *gendev,

dev = alloc_etherdev(sizeof(*vp));
retval = -ENOMEM;
if (!dev) {
pr_err(PFX "unable to allocate etherdev, aborting\n");
if (!dev)
goto out;
}

SET_NETDEV_DEV(dev, gendev);
vp = netdev_priv(dev);

Expand Down
5 changes: 2 additions & 3 deletions drivers/net/ethernet/adaptec/starfire.c
Original file line number Diff line number Diff line change
Expand Up @@ -686,10 +686,9 @@ static int __devinit starfire_init_one(struct pci_dev *pdev,
}

dev = alloc_etherdev(sizeof(*np));
if (!dev) {
printk(KERN_ERR DRV_NAME " %d: cannot alloc etherdev, aborting\n", card_idx);
if (!dev)
return -ENOMEM;
}

SET_NETDEV_DEV(dev, &pdev->dev);

irq = pdev->irq;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/adi/bfin_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1467,10 +1467,8 @@ static int __devinit bfin_mac_probe(struct platform_device *pdev)
int rc;

ndev = alloc_etherdev(sizeof(struct bfin_mac_local));
if (!ndev) {
dev_err(&pdev->dev, "Cannot allocate net device!\n");
if (!ndev)
return -ENOMEM;
}

SET_NETDEV_DEV(ndev, &pdev->dev);
platform_set_drvdata(pdev, ndev);
Expand Down
5 changes: 1 addition & 4 deletions drivers/net/ethernet/alteon/acenic.c
Original file line number Diff line number Diff line change
Expand Up @@ -463,11 +463,8 @@ static int __devinit acenic_probe_one(struct pci_dev *pdev,
static int boards_found;

dev = alloc_etherdev(sizeof(struct ace_private));
if (dev == NULL) {
printk(KERN_ERR "acenic: Unable to allocate "
"net_device structure!\n");
if (dev == NULL)
return -ENOMEM;
}

SET_NETDEV_DEV(dev, &pdev->dev);

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/amd/amd8111e.c
Original file line number Diff line number Diff line change
Expand Up @@ -1859,7 +1859,6 @@ static int __devinit amd8111e_probe_one(struct pci_dev *pdev,

dev = alloc_etherdev(sizeof(struct amd8111e_priv));
if (!dev) {
printk(KERN_ERR "amd8111e: Etherdev alloc failed, exiting.\n");
err = -ENOMEM;
goto err_free_reg;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/amd/au1000_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,6 @@ static int __devinit au1000_probe(struct platform_device *pdev)

dev = alloc_etherdev(sizeof(struct au1000_private));
if (!dev) {
dev_err(&pdev->dev, "alloc_etherdev failed\n");
err = -ENOMEM;
goto err_alloc;
}
Expand Down
2 changes: 0 additions & 2 deletions drivers/net/ethernet/amd/declance.c
Original file line number Diff line number Diff line change
Expand Up @@ -1052,8 +1052,6 @@ static int __devinit dec_lance_probe(struct device *bdev, const int type)

dev = alloc_etherdev(sizeof(struct lance_private));
if (!dev) {
printk(KERN_ERR "%s: Unable to allocate etherdev, aborting.\n",
name);
ret = -ENOMEM;
goto err_out;
}
Expand Down
2 changes: 0 additions & 2 deletions drivers/net/ethernet/amd/pcnet32.c
Original file line number Diff line number Diff line change
Expand Up @@ -1649,8 +1649,6 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev)

dev = alloc_etherdev(sizeof(*lp));
if (!dev) {
if (pcnet32_debug & NETIF_MSG_PROBE)
pr_err("Memory allocation failed\n");
ret = -ENOMEM;
goto err_release_region;
}
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/apple/bmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1269,10 +1269,8 @@ static int __devinit bmac_probe(struct macio_dev *mdev, const struct of_device_i
memcpy(addr, prop_addr, sizeof(addr));

dev = alloc_etherdev(PRIV_BYTES);
if (!dev) {
printk(KERN_ERR "BMAC: alloc_etherdev failed, out of memory\n");
if (!dev)
return -ENOMEM;
}

bp = netdev_priv(dev);
SET_NETDEV_DEV(dev, &mdev->ofdev.dev);
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/apple/mace.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ static int __devinit mace_probe(struct macio_dev *mdev, const struct of_device_i

dev = alloc_etherdev(PRIV_BYTES);
if (!dev) {
printk(KERN_ERR "MACE: can't allocate ethernet device !\n");
rc = -ENOMEM;
goto err_release;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/atheros/atl1c/atl1c_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2689,7 +2689,6 @@ static int __devinit atl1c_probe(struct pci_dev *pdev,
netdev = alloc_etherdev(sizeof(struct atl1c_adapter));
if (netdev == NULL) {
err = -ENOMEM;
dev_err(&pdev->dev, "etherdev alloc failed\n");
goto err_alloc_etherdev;
}

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/atheros/atl1e/atl1e_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2300,7 +2300,6 @@ static int __devinit atl1e_probe(struct pci_dev *pdev,
netdev = alloc_etherdev(sizeof(struct atl1e_adapter));
if (netdev == NULL) {
err = -ENOMEM;
dev_err(&pdev->dev, "etherdev alloc failed\n");
goto err_alloc_etherdev;
}

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/broadcom/b44.c
Original file line number Diff line number Diff line change
Expand Up @@ -2138,7 +2138,6 @@ static int __devinit b44_init_one(struct ssb_device *sdev,

dev = alloc_etherdev(sizeof(*bp));
if (!dev) {
dev_err(sdev->dev, "Etherdev alloc failed, aborting\n");
err = -ENOMEM;
goto out;
}
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -11133,10 +11133,8 @@ static int __devinit bnx2x_init_one(struct pci_dev *pdev,

/* dev zeroed in init_etherdev */
dev = alloc_etherdev_mqs(sizeof(*bp), tx_count, rx_count);
if (!dev) {
dev_err(&pdev->dev, "Cannot allocate net device\n");
if (!dev)
return -ENOMEM;
}

bp = netdev_priv(dev);

Expand Down
2 changes: 0 additions & 2 deletions drivers/net/ethernet/broadcom/sb1250-mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2623,8 +2623,6 @@ static int __devinit sbmac_probe(struct platform_device *pldev)
*/
dev = alloc_etherdev(sizeof(struct sbmac_softc));
if (!dev) {
printk(KERN_ERR "%s: unable to allocate etherdev\n",
dev_name(&pldev->dev));
err = -ENOMEM;
goto out_unmap;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/broadcom/tg3.c
Original file line number Diff line number Diff line change
Expand Up @@ -15471,7 +15471,6 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,

dev = alloc_etherdev_mq(sizeof(*tp), TG3_IRQ_MAX_VECS);
if (!dev) {
dev_err(&pdev->dev, "Etherdev alloc failed, aborting\n");
err = -ENOMEM;
goto err_out_power_down;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/brocade/bna/bnad.c
Original file line number Diff line number Diff line change
Expand Up @@ -3284,7 +3284,6 @@ bnad_pci_probe(struct pci_dev *pdev,
*/
netdev = alloc_etherdev(sizeof(struct bnad));
if (!netdev) {
dev_err(&pdev->dev, "netdev allocation failed\n");
err = -ENOMEM;
return err;
}
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/cadence/macb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1308,10 +1308,8 @@ static int __init macb_probe(struct platform_device *pdev)

err = -ENOMEM;
dev = alloc_etherdev(sizeof(*bp));
if (!dev) {
dev_err(&pdev->dev, "etherdev alloc failed, aborting.\n");
if (!dev)
goto err_out;
}

SET_NETDEV_DEV(dev, &pdev->dev);

Expand Down
2 changes: 0 additions & 2 deletions drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2596,8 +2596,6 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
netdev = alloc_etherdev_mq(sizeof(struct port_info),
MAX_PORT_QSETS);
if (netdev == NULL) {
dev_err(&pdev->dev, "cannot allocate netdev for"
" port %d\n", port_id);
t4vf_free_vi(adapter, viid);
err = -ENOMEM;
goto err_free_dev;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/cisco/enic/enic_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2280,10 +2280,8 @@ static int __devinit enic_probe(struct pci_dev *pdev,
*/

netdev = alloc_etherdev(sizeof(struct enic));
if (!netdev) {
pr_err("Etherdev alloc failed, aborting\n");
if (!netdev)
return -ENOMEM;
}

pci_set_drvdata(pdev, netdev);

Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/davicom/dm9000.c
Original file line number Diff line number Diff line change
Expand Up @@ -1373,10 +1373,8 @@ dm9000_probe(struct platform_device *pdev)

/* Init network device */
ndev = alloc_etherdev(sizeof(struct board_info));
if (!ndev) {
dev_err(&pdev->dev, "could not allocate device.\n");
if (!ndev)
return -ENOMEM;
}

SET_NETDEV_DEV(ndev, &pdev->dev);

Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/dec/tulip/tulip_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1424,10 +1424,8 @@ static int __devinit tulip_init_one (struct pci_dev *pdev,

/* alloc_etherdev ensures aligned and zeroed private structures */
dev = alloc_etherdev (sizeof (*tp));
if (!dev) {
pr_err("ether device alloc failed, aborting\n");
if (!dev)
return -ENOMEM;
}

SET_NETDEV_DEV(dev, &pdev->dev);
if (pci_resource_len (pdev, 0) < tulip_tbl[chip_idx].io_size) {
Expand Down
5 changes: 2 additions & 3 deletions drivers/net/ethernet/dec/tulip/xircom_cb.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,9 @@ static int __devinit xircom_probe(struct pci_dev *pdev, const struct pci_device_
is available.
*/
dev = alloc_etherdev(sizeof(struct xircom_private));
if (!dev) {
pr_err("%s: failed to allocate etherdev\n", __func__);
if (!dev)
goto device_fail;
}

private = netdev_priv(dev);

/* Allocate the send/receive buffers */
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/dnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -854,10 +854,8 @@ static int __devinit dnet_probe(struct platform_device *pdev)

err = -ENOMEM;
dev = alloc_etherdev(sizeof(*bp));
if (!dev) {
dev_err(&pdev->dev, "etherdev alloc failed, aborting.\n");
if (!dev)
goto err_out_release_mem;
}

/* TODO: Actually, we have some interesting features... */
dev->features |= 0;
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/ethoc.c
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,6 @@ static int __devinit ethoc_probe(struct platform_device *pdev)
/* allocate networking device */
netdev = alloc_etherdev(sizeof(struct ethoc));
if (!netdev) {
dev_err(&pdev->dev, "cannot allocate network device\n");
ret = -ENOMEM;
goto out;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/hp/hp100.c
Original file line number Diff line number Diff line change
Expand Up @@ -2992,7 +2992,6 @@ static int __init hp100_isa_init(void)
for (i = 0; i < HP100_DEVICES && hp100_port[i] != -1; ++i) {
dev = alloc_etherdev(sizeof(struct hp100_private));
if (!dev) {
printk(KERN_WARNING "hp100: no memory for network device\n");
while (cards > 0)
cleanup_dev(hp100_devlist[--cards]);

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/ibm/ehea/ehea_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2980,7 +2980,6 @@ static struct ehea_port *ehea_setup_single_port(struct ehea_adapter *adapter,
dev = alloc_etherdev_mq(sizeof(struct ehea_port), EHEA_MAX_PORT_RES);

if (!dev) {
pr_err("no mem for net_device\n");
ret = -ENOMEM;
goto out_err;
}
Expand Down
6 changes: 2 additions & 4 deletions drivers/net/ethernet/ibm/emac/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2706,11 +2706,9 @@ static int __devinit emac_probe(struct platform_device *ofdev)
/* Allocate our net_device structure */
err = -ENOMEM;
ndev = alloc_etherdev(sizeof(struct emac_instance));
if (!ndev) {
printk(KERN_ERR "%s: could not allocate ethernet device!\n",
np->full_name);
if (!ndev)
goto err_gone;
}

dev = netdev_priv(ndev);
dev->ndev = ndev;
dev->ofdev = ofdev;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/ibm/iseries_veth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,8 @@ static struct net_device *veth_probe_one(int vlan,
}

dev = alloc_etherdev(sizeof (struct veth_port));
if (! dev) {
veth_error("Unable to allocate net_device structure!\n");
if (!dev)
return NULL;
}

port = netdev_priv(dev);

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/icplus/ipg.c
Original file line number Diff line number Diff line change
Expand Up @@ -2233,7 +2233,6 @@ static int __devinit ipg_probe(struct pci_dev *pdev,
*/
dev = alloc_etherdev(sizeof(struct ipg_nic_private));
if (!dev) {
pr_err("%s: alloc_etherdev failed\n", pci_name(pdev));
rc = -ENOMEM;
goto err_disable_0;
}
Expand Down
5 changes: 1 addition & 4 deletions drivers/net/ethernet/intel/e100.c
Original file line number Diff line number Diff line change
Expand Up @@ -2751,11 +2751,8 @@ static int __devinit e100_probe(struct pci_dev *pdev,
struct nic *nic;
int err;

if (!(netdev = alloc_etherdev(sizeof(struct nic)))) {
if (((1 << debug) - 1) & NETIF_MSG_PROBE)
pr_err("Etherdev alloc failed, aborting\n");
if (!(netdev = alloc_etherdev(sizeof(struct nic))))
return -ENOMEM;
}

netdev->netdev_ops = &e100_netdev_ops;
SET_ETHTOOL_OPS(netdev, &e100_ethtool_ops);
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/jme.c
Original file line number Diff line number Diff line change
Expand Up @@ -2999,7 +2999,6 @@ jme_init_one(struct pci_dev *pdev,
*/
netdev = alloc_etherdev(sizeof(*jme));
if (!netdev) {
pr_err("Cannot allocate netdev structure\n");
rc = -ENOMEM;
goto err_out_release_regions;
}
Expand Down
5 changes: 2 additions & 3 deletions drivers/net/ethernet/korina.c
Original file line number Diff line number Diff line change
Expand Up @@ -1108,10 +1108,9 @@ static int korina_probe(struct platform_device *pdev)
int rc;

dev = alloc_etherdev(sizeof(struct korina_private));
if (!dev) {
printk(KERN_ERR DRV_NAME ": alloc_etherdev failed\n");
if (!dev)
return -ENOMEM;
}

SET_NETDEV_DEV(dev, &pdev->dev);
lp = netdev_priv(dev);

Expand Down
4 changes: 4 additions & 0 deletions drivers/net/ethernet/lantiq_etop.c
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,10 @@ ltq_etop_probe(struct platform_device *pdev)
}

dev = alloc_etherdev_mq(sizeof(struct ltq_etop_priv), 4);
if (!dev) {
err = -ENOMEM;
goto err_out;
}
strcpy(dev->name, "eth%d");
dev->netdev_ops = &ltq_eth_netdev_ops;
dev->ethtool_ops = &ltq_etop_ethtool_ops;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/marvell/skge.c
Original file line number Diff line number Diff line change
Expand Up @@ -3852,10 +3852,8 @@ static struct net_device *skge_devinit(struct skge_hw *hw, int port,
struct skge_port *skge;
struct net_device *dev = alloc_etherdev(sizeof(*skge));

if (!dev) {
dev_err(&hw->pdev->dev, "etherdev alloc failed\n");
if (!dev)
return NULL;
}

SET_NETDEV_DEV(dev, &hw->pdev->dev);
dev->netdev_ops = &skge_netdev_ops;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/marvell/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -4700,10 +4700,8 @@ static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw,
struct sky2_port *sky2;
struct net_device *dev = alloc_etherdev(sizeof(*sky2));

if (!dev) {
dev_err(&hw->pdev->dev, "etherdev alloc failed\n");
if (!dev)
return NULL;
}

SET_NETDEV_DEV(dev, &hw->pdev->dev);
dev->irq = hw->pdev->irq;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/mellanox/mlx4/en_netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1047,10 +1047,8 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,

dev = alloc_etherdev_mqs(sizeof(struct mlx4_en_priv),
prof->tx_ring_num, prof->rx_ring_num);
if (dev == NULL) {
mlx4_err(mdev, "Net device allocation failed\n");
if (dev == NULL)
return -ENOMEM;
}

SET_NETDEV_DEV(dev, &mdev->dev->pdev->dev);
dev->dev_id = port - 1;
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/ethernet/micrel/ks8695net.c
Original file line number Diff line number Diff line change
Expand Up @@ -1362,10 +1362,8 @@ ks8695_probe(struct platform_device *pdev)

/* Initialise a net_device */
ndev = alloc_etherdev(sizeof(struct ks8695_priv));
if (!ndev) {
dev_err(&pdev->dev, "could not allocate device.\n");
if (!ndev)
return -ENOMEM;
}

SET_NETDEV_DEV(ndev, &pdev->dev);

Expand Down
Loading

0 comments on commit 41de8d4

Please sign in to comment.