Skip to content

Commit

Permalink
USB: sisusbvga: Remove the BKL from ioctl
Browse files Browse the repository at this point in the history
Seems to me that BKL is not needed here because necessary locking is already
provided by mutex sisusb->lock.

Also change the returned value to long.

Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alessio Igor Bogani authored and Greg Kroah-Hartman committed May 20, 2010
1 parent d20db4b commit 41f2c6e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/usb/misc/sisusbvga/sisusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -2974,13 +2974,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct sisusb_usb_data *sisusb;
struct sisusb_info x;
struct sisusb_command y;
int retval = 0;
long retval = 0;
u32 __user *argp = (u32 __user *)arg;

if (!(sisusb = (struct sisusb_usb_data *)file->private_data))
return -ENODEV;

lock_kernel();
mutex_lock(&sisusb->lock);

/* Sanity check */
Expand Down Expand Up @@ -3039,7 +3038,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)

err_out:
mutex_unlock(&sisusb->lock);
unlock_kernel();
return retval;
}

Expand Down

0 comments on commit 41f2c6e

Please sign in to comment.