Skip to content

Commit

Permalink
spi/panel: dt-bindings: drop 3-wire from common properties
Browse files Browse the repository at this point in the history
The spi-3wire property is device specific and should be accepted only if
device really needs them.  Drop it from common spi-peripheral-props.yaml
schema, mention in few panel drivers which use it and include instead in
the SPI controller bindings.  The controller bindings will provide
spi-3wire type validation and one place for description.  Each device
schema must list the property if it is applicable.

The Samsung S6E63M0 panel uses also spi-cpha/cpol properties on at least
one board (ste-ux500-samsung-janice/dts), so add also these to the
panel's bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220810131311.428645-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Krzysztof Kozlowski authored and Mark Brown committed Aug 15, 2022
1 parent 0df874c commit 41f53a6
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ properties:
reg: true
reset-gpios: true

spi-3wire: true

required:
- compatible
- power-supply
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ properties:
reg: true
reset-gpios: true

spi-3wire: true

required:
- compatible
- power-supply
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ properties:
default-brightness: true
max-brightness: true

spi-3wire: true
spi-cpha: true
spi-cpol: true

vdd3-supply:
description: VDD regulator

Expand Down
5 changes: 5 additions & 0 deletions Documentation/devicetree/bindings/spi/spi-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ patternProperties:
$ref: spi-peripheral-props.yaml

properties:
spi-3wire:
$ref: /schemas/types.yaml#/definitions/flag
description:
The device requires 3-wire mode.

spi-cpha:
$ref: /schemas/types.yaml#/definitions/flag
description:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ properties:
description:
Chip select used by the device.

spi-3wire:
$ref: /schemas/types.yaml#/definitions/flag
description:
The device requires 3-wire mode.

spi-cs-high:
$ref: /schemas/types.yaml#/definitions/flag
description:
Expand Down

0 comments on commit 41f53a6

Please sign in to comment.