Skip to content

Commit

Permalink
PM / hibernate: use name_to_dev_t to parse resume
Browse files Browse the repository at this point in the history
Use the name_to_dev_t call to parse the device name echo'd to
to /sys/power/resume.  This imitates the method used in hibernate.c
in software_resume, and allows the resume partition to be specified
using other equivalent device formats as well.  By allowing
/sys/debug/resume to accept the same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.

Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Sebastian Capella authored and Rafael J. Wysocki committed Mar 1, 2014
1 parent 6c5be29 commit 421a5fa
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions kernel/power/hibernate.c
Original file line number Diff line number Diff line change
Expand Up @@ -973,26 +973,28 @@ static ssize_t resume_show(struct kobject *kobj, struct kobj_attribute *attr,
static ssize_t resume_store(struct kobject *kobj, struct kobj_attribute *attr,
const char *buf, size_t n)
{
unsigned int maj, min;
dev_t res;
int ret = -EINVAL;
int len = n;
char *name;

if (sscanf(buf, "%u:%u", &maj, &min) != 2)
goto out;
if (len && buf[len-1] == '\n')
len--;
name = kstrndup(buf, len, GFP_KERNEL);
if (!name)
return -ENOMEM;

res = MKDEV(maj,min);
if (maj != MAJOR(res) || min != MINOR(res))
goto out;
res = name_to_dev_t(name);
kfree(name);
if (!res)
return -EINVAL;

lock_system_sleep();
swsusp_resume_device = res;
unlock_system_sleep();
printk(KERN_INFO "PM: Starting manual resume from disk\n");
noresume = 0;
software_resume();
ret = n;
out:
return ret;
return n;
}

power_attr(resume);
Expand Down

0 comments on commit 421a5fa

Please sign in to comment.