Skip to content

Commit

Permalink
iommu/sprd: Convert to platform remove callback returning void
Browse files Browse the repository at this point in the history
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230321084125.337021-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Uwe Kleine-König authored and Joerg Roedel committed Mar 31, 2023
1 parent 5930df6 commit 421b609
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/iommu/sprd-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ static int sprd_iommu_probe(struct platform_device *pdev)
return ret;
}

static int sprd_iommu_remove(struct platform_device *pdev)
static void sprd_iommu_remove(struct platform_device *pdev)
{
struct sprd_iommu_device *sdev = platform_get_drvdata(pdev);

Expand All @@ -519,8 +519,6 @@ static int sprd_iommu_remove(struct platform_device *pdev)
platform_set_drvdata(pdev, NULL);
iommu_device_sysfs_remove(&sdev->iommu);
iommu_device_unregister(&sdev->iommu);

return 0;
}

static struct platform_driver sprd_iommu_driver = {
Expand All @@ -530,7 +528,7 @@ static struct platform_driver sprd_iommu_driver = {
.suppress_bind_attrs = true,
},
.probe = sprd_iommu_probe,
.remove = sprd_iommu_remove,
.remove_new = sprd_iommu_remove,
};
module_platform_driver(sprd_iommu_driver);

Expand Down

0 comments on commit 421b609

Please sign in to comment.