Skip to content

Commit

Permalink
zsmalloc: no need to check return value of debugfs_create functions
Browse files Browse the repository at this point in the history
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: linux-mm@kvack.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Jun 3, 2019
1 parent 3e6f176 commit 4268509
Showing 1 changed file with 4 additions and 18 deletions.
22 changes: 4 additions & 18 deletions mm/zsmalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,6 @@ static void __init zs_stat_init(void)
}

zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
if (!zs_stat_root)
pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
}

static void __exit zs_stat_exit(void)
Expand Down Expand Up @@ -654,22 +652,10 @@ static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
return;
}

entry = debugfs_create_dir(name, zs_stat_root);
if (!entry) {
pr_warn("debugfs dir <%s> creation failed\n", name);
return;
}
pool->stat_dentry = entry;

entry = debugfs_create_file("classes", S_IFREG | 0444,
pool->stat_dentry, pool,
&zs_stats_size_fops);
if (!entry) {
pr_warn("%s: debugfs file entry <%s> creation failed\n",
name, "classes");
debugfs_remove_recursive(pool->stat_dentry);
pool->stat_dentry = NULL;
}
pool->stat_dentry = debugfs_create_dir(name, zs_stat_root);

debugfs_create_file("classes", S_IFREG | 0444, pool->stat_dentry, pool,
&zs_stats_size_fops);
}

static void zs_pool_stat_destroy(struct zs_pool *pool)
Expand Down

0 comments on commit 4268509

Please sign in to comment.