Skip to content

Commit

Permalink
RDMA/core: Document CM @event_handler function
Browse files Browse the repository at this point in the history
Code audit suggests that the RDMA CM event handler callback function is
_always_ invoked in a context that is safe to block. That's important for
consumer implementers to know, so document that in the comment before
rdma_create_id (where the handler function is set up by the consumer).

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
  • Loading branch information
Chuck Lever authored and Jason Gunthorpe committed Sep 11, 2018
1 parent 2739935 commit 4269024
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion include/rdma/rdma_cm.h
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,11 @@ struct rdma_cm_id *__rdma_create_id(struct net *net,
* @ps: RDMA port space.
* @qp_type: type of queue pair associated with the id.
*
* The id holds a reference on the network namespace until it is destroyed.
* Returns a new rdma_cm_id. The id holds a reference on the network
* namespace until it is destroyed.
*
* The event handler callback serializes on the id's mutex and is
* allowed to sleep.
*/
#define rdma_create_id(net, event_handler, context, ps, qp_type) \
__rdma_create_id((net), (event_handler), (context), (ps), (qp_type), \
Expand Down

0 comments on commit 4269024

Please sign in to comment.