Skip to content

Commit

Permalink
staging: fbtft: Fix error path in fbtft_driver_module_init()
Browse files Browse the repository at this point in the history
If registering the platform driver fails, the function must not return
without undoing the spi driver registration first.

Fixes: c296d5f ("staging: fbtft: core support")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220118181338.207943-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Uwe Kleine-König authored and Greg Kroah-Hartman committed Jan 25, 2022
1 parent 0cea730 commit 426aca1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/staging/fbtft/fbtft.h
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,10 @@ static int __init fbtft_driver_module_init(void) \
ret = spi_register_driver(&fbtft_driver_spi_driver); \
if (ret < 0) \
return ret; \
return platform_driver_register(&fbtft_driver_platform_driver); \
ret = platform_driver_register(&fbtft_driver_platform_driver); \
if (ret < 0) \
spi_unregister_driver(&fbtft_driver_spi_driver); \
return ret; \
} \
\
static void __exit fbtft_driver_module_exit(void) \
Expand Down

0 comments on commit 426aca1

Please sign in to comment.