Skip to content

Commit

Permalink
serial: uartps: Change logic how console_port is setup
Browse files Browse the repository at this point in the history
Change logic how console_port is setup by using CON_ENABLED flag
instead of index. There will be unique cdns_uart_console() structures
that's why code can't use id for console_port assignment.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Michal Simek authored and Greg Kroah-Hartman committed Sep 18, 2018
1 parent 10a5315 commit 427c8ae
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions drivers/tty/serial/xilinx_uartps.c
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,7 @@ static int cdns_uart_probe(struct platform_device *pdev)
* If register_console() don't assign value, then console_port pointer
* is cleanup.
*/
if (cdns_uart_uart_driver.cons->index == -1)
if (!console_port)
console_port = port;
#endif

Expand All @@ -1546,7 +1546,8 @@ static int cdns_uart_probe(struct platform_device *pdev)

#ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE
/* This is not port which is used for console that's why clean it up */
if (cdns_uart_uart_driver.cons->index == -1)
if (console_port == port &&
!(cdns_uart_uart_driver.cons->flags & CON_ENABLED))
console_port = NULL;
#endif

Expand Down Expand Up @@ -1595,6 +1596,12 @@ static int cdns_uart_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
pm_runtime_set_suspended(&pdev->dev);
pm_runtime_dont_use_autosuspend(&pdev->dev);

#ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE
if (console_port == port)
console_port = NULL;
#endif

if (!--instances)
uart_unregister_driver(cdns_uart_data->cdns_uart_driver);
return rc;
Expand Down

0 comments on commit 427c8ae

Please sign in to comment.