Skip to content

Commit

Permalink
serial: imx: drop check for enabled dma in .startup
Browse files Browse the repository at this point in the history
imx_shutdown() calls imx_disable_dma if .dma_is_enabled. So after
imx_shudown() completes, .dma_is_enabled is zero. For this reason
.dma_is_enabled is also zero when imx_startup() is called. So the check
for this variable being zero can be dropped.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Uwe Kleine-König authored and Greg Kroah-Hartman committed Feb 28, 2018
1 parent 4238c00 commit 42afa62
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/serial/imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ static int imx_startup(struct uart_port *port)
writel(USR1_RTSD | USR1_DTRD, sport->port.membase + USR1);
writel(USR2_ORE, sport->port.membase + USR2);

if (dma_is_inited && !sport->dma_is_enabled)
if (dma_is_inited)
imx_enable_dma(sport);

temp = readl(sport->port.membase + UCR1) & ~UCR1_RRDYEN;
Expand Down

0 comments on commit 42afa62

Please sign in to comment.