Skip to content

Commit

Permalink
RDMA/rtrs-srv: More debugging info when fail to send reply
Browse files Browse the repository at this point in the history
It does not help to debug if it only print error message
without any debugging information which session and connection
the error happened.

Link: https://lore.kernel.org/r/20210406123639.202899-3-gi-oh.kim@ionos.com
Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
  • Loading branch information
Gioh Kim authored and Jason Gunthorpe committed Apr 13, 2021
1 parent 2f37b01 commit 42cdc19
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/infiniband/ulp/rtrs/rtrs-srv.c
Original file line number Diff line number Diff line change
Expand Up @@ -518,8 +518,9 @@ bool rtrs_srv_resp_rdma(struct rtrs_srv_op *id, int status)

if (unlikely(sess->state != RTRS_SRV_CONNECTED)) {
rtrs_err_rl(s,
"Sending I/O response failed, session is disconnected, sess state %s\n",
rtrs_srv_state_str(sess->state));
"Sending I/O response failed, session %s is disconnected, sess state %s\n",
kobject_name(&sess->kobj),
rtrs_srv_state_str(sess->state));
goto out;
}
if (always_invalidate) {
Expand All @@ -529,7 +530,9 @@ bool rtrs_srv_resp_rdma(struct rtrs_srv_op *id, int status)
}
if (unlikely(atomic_sub_return(1,
&con->sq_wr_avail) < 0)) {
pr_err("IB send queue full\n");
rtrs_err(s, "IB send queue full: sess=%s cid=%d\n",
kobject_name(&sess->kobj),
con->c.cid);
atomic_add(1, &con->sq_wr_avail);
spin_lock(&con->rsp_wr_wait_lock);
list_add_tail(&id->wait_list, &con->rsp_wr_wait_list);
Expand All @@ -543,7 +546,8 @@ bool rtrs_srv_resp_rdma(struct rtrs_srv_op *id, int status)
err = rdma_write_sg(id);

if (unlikely(err)) {
rtrs_err_rl(s, "IO response failed: %d\n", err);
rtrs_err_rl(s, "IO response failed: %d: sess=%s\n", err,
kobject_name(&sess->kobj));
close_sess(sess);
}
out:
Expand Down

0 comments on commit 42cdc19

Please sign in to comment.