Skip to content

Commit

Permalink
intel_pstate: constify local structures
Browse files Browse the repository at this point in the history
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.

Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Julia Lawall authored and Rafael J. Wysocki committed Sep 13, 2016
1 parent 297a662 commit 42ce892
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/cpufreq/intel_pstate.c
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ static struct cpu_defaults core_params = {
},
};

static struct cpu_defaults silvermont_params = {
static const struct cpu_defaults silvermont_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
Expand All @@ -1050,7 +1050,7 @@ static struct cpu_defaults silvermont_params = {
},
};

static struct cpu_defaults airmont_params = {
static const struct cpu_defaults airmont_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
Expand All @@ -1071,7 +1071,7 @@ static struct cpu_defaults airmont_params = {
},
};

static struct cpu_defaults knl_params = {
static const struct cpu_defaults knl_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
Expand All @@ -1091,7 +1091,7 @@ static struct cpu_defaults knl_params = {
},
};

static struct cpu_defaults bxt_params = {
static const struct cpu_defaults bxt_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
Expand Down

0 comments on commit 42ce892

Please sign in to comment.