Skip to content

Commit

Permalink
serial: 8250_fintek: Fix finding base_port with activated SuperIO
Browse files Browse the repository at this point in the history
commit fd97e66 upstream.

The SuperIO will be configured at boot time by BIOS, but some BIOS
will not deactivate the SuperIO when the end of configuration. It'll
lead to mismatch for pdata->base_port in probe_setup_port(). So we'll
deactivate all SuperIO before activate special base_port in
fintek_8250_enter_key().

Tested on iBASE MI802.

Tested-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
Reviewd-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ji-Ze Hong (Peter Hong) authored and Greg Kroah-Hartman committed Nov 24, 2017
1 parent c75289a commit 432a1a5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/tty/serial/8250/8250_fintek.c
Original file line number Diff line number Diff line change
@@ -118,6 +118,9 @@ static int fintek_8250_enter_key(u16 base_port, u8 key)
if (!request_muxed_region(base_port, 2, "8250_fintek"))
return -EBUSY;

/* Force to deactive all SuperIO in this base_port */
outb(EXIT_KEY, base_port + ADDR_PORT);

outb(key, base_port + ADDR_PORT);
outb(key, base_port + ADDR_PORT);
return 0;

0 comments on commit 432a1a5

Please sign in to comment.