Skip to content

Commit

Permalink
hrtimer: remove duplicate helper function
Browse files Browse the repository at this point in the history
The helper function hrtimer_callback_running() is used in
kernel/hrtimer.c as well as in the updated net/can/bcm.c which now
supports hrtimers. Moving the helper function to hrtimer.h removes the
duplicate definition in the C-files.

Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Oliver Hartkopp authored and Thomas Gleixner committed May 3, 2008
1 parent b66e1f1 commit 4346f65
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
9 changes: 9 additions & 0 deletions include/linux/hrtimer.h
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,15 @@ static inline int hrtimer_is_queued(struct hrtimer *timer)
(HRTIMER_STATE_ENQUEUED | HRTIMER_STATE_PENDING);
}

/*
* Helper function to check, whether the timer is running the callback
* function
*/
static inline int hrtimer_callback_running(struct hrtimer *timer)
{
return timer->state & HRTIMER_STATE_CALLBACK;
}

/* Forward a hrtimer so it expires after now: */
extern u64
hrtimer_forward(struct hrtimer *timer, ktime_t now, ktime_t interval);
Expand Down
9 changes: 0 additions & 9 deletions kernel/hrtimer.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,6 @@ static void hrtimer_get_softirq_time(struct hrtimer_cpu_base *base)
ktime_add(xtim, tomono);
}

/*
* Helper function to check, whether the timer is running the callback
* function
*/
static inline int hrtimer_callback_running(struct hrtimer *timer)
{
return timer->state & HRTIMER_STATE_CALLBACK;
}

/*
* Functions and macros which are different for UP/SMP systems are kept in a
* single place
Expand Down
6 changes: 0 additions & 6 deletions net/can/bcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,12 +412,6 @@ static void bcm_rx_changed(struct bcm_op *op, struct can_frame *data)
bcm_send_to_user(op, &head, data, 1);
}

/* TODO: move to linux/hrtimer.h */
static inline int hrtimer_callback_running(struct hrtimer *timer)
{
return timer->state & HRTIMER_STATE_CALLBACK;
}

/*
* bcm_rx_update_and_send - process a detected relevant receive content change
* 1. update the last received data
Expand Down

0 comments on commit 4346f65

Please sign in to comment.